Enable strict compilation #27009
Merged
Enable strict compilation #27009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning waves included some but not all checks from strict. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks @sharwell. |
ajcvickers
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the compiler "strict" option. No new errors were generated as a result; I suspect that the recent "warning waves" feature simply integrated all of strict's diagnostics and made it unneeded - but there doesn't seem to be any harm in enabling it.
@sharwell any comment?
Closes #14502